-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiles/coreos: Account for python versions with minor > 10 #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous expression (sys.version[:3])) truncates 3.10 to 3.1 leading to build failures in some ebuilds that depend on python. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
krnowak
approved these changes
Jul 7, 2023
Next update, when minor is >100 or when major is >10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't truncate python minor in profile
sys.version
returns3.10.12 (main, Jul 6 2023, 22:54:08) [GCC 12.2.1 20230428]
.The previous expression (sys.version[:3])) truncates 3.10 to 3.1 leading to build failures in some ebuilds that depend on python (like zfs).
How to use
Don't know which ebuilds (other than sys-fs/zfs) use this but the problem is obvious.
Testing done
Built zfs sysext.
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.