Optionally throw error for unsupported arguments #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling d0146eb on 18F:master into * on flask-restful:master*. |
1 similar comment
|
Changes Unknown when pulling d0146eb on 18F:master into * on flask-restful:master*. |
| def test_strict_parsing_on(self): | ||
| req = Request.from_values("/bubble?foo=baz") | ||
| parser = RequestParser() | ||
| with self.assertRaises(exceptions.BadRequest): |
There was a problem hiding this comment.
Looks like this style is not supported in unittest under python2.6. This should work instead:
self.assertRaises(exceptions.BadRequest, parser.parse_args, req, strict=True)
|
Changes Unknown when pulling 9c3be74 on 18F:master into * on flask-restful:master*. |
| """Parse all arguments from the provided request and return the results | ||
| as a Namespace | ||
|
|
||
| if ``strict``, then parsing req with args not in parser will throw exception |
|
Changes Unknown when pulling 6b56800 on 18F:master into * on flask-restful:master*. |
joshfriend
added a commit
that referenced
this pull request
Dec 13, 2014
Optionally throw error for unsupported arguments
|
Thanks for taking care of this @catherinedevlin! |
|
Happy to! Thanks for the coaching! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my suggested implementation for issue #355
I'm open to suggestions from the web-savvier if there's a more appropriate response than BadRequest.