Add "Allow" header to HTTP 405 error. #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By RFC7231 (http://tools.ietf.org/html/rfc7231#section-6.5.5) 405 status must generate Allow header with list of resource's supported methods.
|
LGTM. Can you whip up a test case real quick? |
In python 3.2+ unittest.TestCase.assertItemsEqual method was replaced by assertCountEqual method. See http://bugs.python.org/issue17866.
|
Tested. |
|
Very nice. thank you! |
joshfriend
added a commit
that referenced
this pull request
Nov 19, 2014
Add "Allow" header to HTTP 405 error.
joshfriend
pushed a commit
that referenced
this pull request
Nov 21, 2014
joshfriend
pushed a commit
that referenced
this pull request
Nov 21, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By RFC7231 405 status must generate Allow header with list of resource's supported methods.