Avoid unicode LookupError #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`six.text_type` is `unicode` on Python 2 and `str` on Python 3. Both of these functions accept multiple parameters: the second is the `encoding` parameter. According to the documentation: "The encoding parameter is a string giving the name of an encoding; if the encoding is not known, `LookupError` is raised." Because `LookupError` does not inherit from `TypeError`, it is not caught by the try/catch blocks, and can result in Flask-Restful returning a 400 status code response. This commit changes the default type to a wrapper around `six.text_type` that only takes one parameter. This way, an encoding will never be specified, and it will never raise a `LookupError`.
|
LGTM. Thanks! |
|
Wondering if we should move this to types.py to avoid the lambda.. |
This was referenced Jan 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
six.text_typeisunicodeon Python 2 andstron Python 3. Both of thesefunctions accept multiple parameters: the second is the
encodingparameter.According to the documentation: "The encoding parameter is a string giving the
name of an encoding; if the encoding is not known,
LookupErroris raised."Because
LookupErrordoes not inherit fromTypeError, it is not caught bythe try/catch blocks, and can result in Flask-Restful returning a 400 status
code response.
This commit changes the default type to a wrapper around
six.text_typethatonly takes one parameter. This way, an encoding will never be specified, and it
will never raise a
LookupError.