Fix some CMake issues #901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Make sure the name of the exported target is `imgclass`, not `imclass` - Export some variables denoting flashlight backend - Enable CUDA in example (and wav2letter) builds if fl is built with CUDA - Bump minimum CMake version in wav2letter - Bump w2l to C++14 Differential Revision: D25163993 fbshipit-source-id: 7061679ca8d29144e145637e1a6132048065a57a
|
This pull request was exported from Phabricator. Differential Revision: D25163993 |
facebook-github-bot
pushed a commit
to flashlight/flashlight
that referenced
this pull request
Nov 24, 2020
Summary: Pull Request resolved: flashlight/wav2letter#901 Pull Request resolved: #281 - Make sure the name of the exported target is `imgclass`, not `imclass` - Export some variables denoting flashlight backend - Enable CUDA in example (and wav2letter) builds if fl is built with CUDA - Bump minimum CMake version in wav2letter - Bump w2l to C++14 Reviewed By: tlikhomanenko Differential Revision: D25163993 fbshipit-source-id: 1af02fd50f0c7570f8811035f7217881052668d5
|
This pull request has been merged in c61fac3. |
jacobkahn
added a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: flashlight/wav2letter#901 Pull Request resolved: flashlight/flashlight#281 - Make sure the name of the exported target is `imgclass`, not `imclass` - Export some variables denoting flashlight backend - Enable CUDA in example (and wav2letter) builds if fl is built with CUDA - Bump minimum CMake version in wav2letter - Bump w2l to C++14 Reviewed By: tlikhomanenko Differential Revision: D25163993 fbshipit-source-id: 1af02fd50f0c7570f8811035f7217881052668d5
jacobkahn
added a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: flashlight/wav2letter#901 Pull Request resolved: flashlight/flashlight#281 - Make sure the name of the exported target is `imgclass`, not `imclass` - Export some variables denoting flashlight backend - Enable CUDA in example (and wav2letter) builds if fl is built with CUDA - Bump minimum CMake version in wav2letter - Bump w2l to C++14 Reviewed By: tlikhomanenko Differential Revision: D25163993 fbshipit-source-id: 1af02fd50f0c7570f8811035f7217881052668d5
jacobkahn
added a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: flashlight/wav2letter#901 Pull Request resolved: flashlight/flashlight#281 - Make sure the name of the exported target is `imgclass`, not `imclass` - Export some variables denoting flashlight backend - Enable CUDA in example (and wav2letter) builds if fl is built with CUDA - Bump minimum CMake version in wav2letter - Bump w2l to C++14 Reviewed By: tlikhomanenko Differential Revision: D25163993 fbshipit-source-id: 1af02fd50f0c7570f8811035f7217881052668d5
jacobkahn
added a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: flashlight/wav2letter#901 Pull Request resolved: flashlight/flashlight#281 - Make sure the name of the exported target is `imgclass`, not `imclass` - Export some variables denoting flashlight backend - Enable CUDA in example (and wav2letter) builds if fl is built with CUDA - Bump minimum CMake version in wav2letter - Bump w2l to C++14 Reviewed By: tlikhomanenko Differential Revision: D25163993 fbshipit-source-id: 1af02fd50f0c7570f8811035f7217881052668d5
jacobkahn
added a commit
to flashlight/sequence
that referenced
this pull request
Oct 13, 2022
Summary: Pull Request resolved: flashlight/wav2letter#901 Pull Request resolved: flashlight/flashlight#281 - Make sure the name of the exported target is `imgclass`, not `imclass` - Export some variables denoting flashlight backend - Enable CUDA in example (and wav2letter) builds if fl is built with CUDA - Bump minimum CMake version in wav2letter - Bump w2l to C++14 Reviewed By: tlikhomanenko Differential Revision: D25163993 fbshipit-source-id: 1af02fd50f0c7570f8811035f7217881052668d5
jacobkahn
added a commit
to flashlight/sequence
that referenced
this pull request
Oct 13, 2022
Summary: Pull Request resolved: flashlight/wav2letter#901 Pull Request resolved: flashlight/flashlight#281 - Make sure the name of the exported target is `imgclass`, not `imclass` - Export some variables denoting flashlight backend - Enable CUDA in example (and wav2letter) builds if fl is built with CUDA - Bump minimum CMake version in wav2letter - Bump w2l to C++14 Reviewed By: tlikhomanenko Differential Revision: D25163993 fbshipit-source-id: 1af02fd50f0c7570f8811035f7217881052668d5
jacobkahn
added a commit
to flashlight/sequence
that referenced
this pull request
Oct 13, 2022
Summary: Pull Request resolved: flashlight/wav2letter#901 Pull Request resolved: flashlight/flashlight#281 - Make sure the name of the exported target is `imgclass`, not `imclass` - Export some variables denoting flashlight backend - Enable CUDA in example (and wav2letter) builds if fl is built with CUDA - Bump minimum CMake version in wav2letter - Bump w2l to C++14 Reviewed By: tlikhomanenko Differential Revision: D25163993 fbshipit-source-id: 1af02fd50f0c7570f8811035f7217881052668d5
jacobkahn
added a commit
to flashlight/sequence
that referenced
this pull request
Oct 13, 2022
Summary: Pull Request resolved: flashlight/wav2letter#901 Pull Request resolved: flashlight/flashlight#281 - Make sure the name of the exported target is `imgclass`, not `imclass` - Export some variables denoting flashlight backend - Enable CUDA in example (and wav2letter) builds if fl is built with CUDA - Bump minimum CMake version in wav2letter - Bump w2l to C++14 Reviewed By: tlikhomanenko Differential Revision: D25163993 fbshipit-source-id: 1af02fd50f0c7570f8811035f7217881052668d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
imgclass, notimclassDifferential Revision: D25163993