Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding colab and small fixes for multilingual model recipe #1003

Closed
wants to merge 7 commits into from

Conversation

lorenlugosch
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first. Changes must be discussed.

Original Issue: n/a

Note: You can add closes #[issue number] to automatically close the issue that this PR resolves when it is merged.

Summary

adding colab and small fixes for multilingual model recipe

Test Plan (required)

n/a

@facebook-github-bot
Copy link

Hi @lorenlugosch!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link

@vineelpratap has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@lorenlugosch
Copy link
Contributor Author

lorenlugosch commented Feb 21, 2022

todo:

  • change "checkpoint_base_cvft.bin" to e.g. "checkpoint_large_cvft.bin", and then fix notebook

@facebook-github-bot
Copy link

@lorenlugosch has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link

@lorenlugosch has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link

@lorenlugosch has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link

@vineelpratap has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants