Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable goerr113 check #45

Merged
merged 7 commits into from
Aug 10, 2022
Merged

Enable goerr113 check #45

merged 7 commits into from
Aug 10, 2022

Conversation

jtraglia
Copy link
Collaborator

@jtraglia jtraglia commented Aug 10, 2022 •
edited
Loading

📝 Summary

  • Enable the goerr113 lint check.
  • Define static errors for everything.
  • Use wrapped errors for extra information.
  • Replace err == blah with errors.Is(blah).

Please merge #43 first.

⛱ Motivation and Context

I think it makes sense to have all of the errors defined at the top. Certainly makes reading code easier.

📚 References

✅ I have run these commands

  • make lint
  • make test
  • go mod tidy

@metachris
Copy link
Collaborator

Looks great, but I've accidentally merged the other PR first and now this one has a conflict

@jtraglia
Copy link
Collaborator Author

No worries. It's an easy fix!

@jtraglia jtraglia merged commit 7428e4c into flashbots:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtraglia @metachris