Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint to checks #43

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Add golangci-lint to checks #43

merged 3 commits into from
Aug 10, 2022

Conversation

jtraglia
Copy link
Collaborator

📝 Summary

  • This adds golangci-lint to make lint which is also called during CI checks.
  • Currently, all of the failing checks are disabled. These will be fixed & enabled in later PRs.

⛱ Motivation and Context

It'll help prevent bugs in the future!

📚 References

✅ I have run these commands

  • make lint
  • make test
  • go mod tidy

@jtraglia
Copy link
Collaborator Author

By the way, added this to make lint instead of a new GitHub Action because I wanted to be able to run everything locally before making commits. And it's still run as part of CI checks. Related to #37.

This was referenced Aug 10, 2022
Merged
Merged
Merged
Merged
@metachris metachris merged commit fcf4bd9 into flashbots:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtraglia @metachris