Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPayload retry with 100ms timeout #465

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

metachris
Copy link
Collaborator

πŸ“ Summary

Wait 100ms until getPayload retry for higher success rate


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@metachris metachris requested review from avalonche and jtraglia March 9, 2023 08:34
Ruteri
Ruteri previously approved these changes Mar 9, 2023
Copy link
Contributor

@Ruteri Ruteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a sleep like this warrants a comment so that we won't get a PR saying "removed the 100ms sleep, performance is 10% better now"

@codecov-commenter
Copy link

Codecov Report

Merging #465 (f73b0a5) into main (20f107f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

πŸ“£ This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   68.62%   68.64%   +0.02%     
==========================================
  Files           8        8              
  Lines        1262     1263       +1     
==========================================
+ Hits          866      867       +1     
  Misses        346      346              
  Partials       50       50              
Flag Coverage Ξ”
unittests 68.64% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
server/utils.go 82.23% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

avalonche
avalonche previously approved these changes Mar 9, 2023
@metachris metachris dismissed stale reviews from avalonche and Ruteri via 5e9e100 March 9, 2023 18:10
@metachris metachris force-pushed the getpayload-retry-timeout branch from f73b0a5 to 5e9e100 Compare March 9, 2023 18:10
@metachris
Copy link
Collaborator Author

added the comment!

@metachris metachris requested review from Ruteri and avalonche March 9, 2023 18:11
Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@metachris metachris merged commit 4f6b07c into main Mar 10, 2023
@metachris metachris deleted the getpayload-retry-timeout branch March 10, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants