Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only set actor on events that have it #3914

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 29, 2023

Fixes #3889

Changes proposed in this pull request:

  • I was going to update update all relevant events so that the actor property is always named actor but I figured that would be too breaking? honestly not sure, but at least this fixes the deprecation warning.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from a team as a code owner October 29, 2023 13:12
@imorland imorland added this to the 2.0 milestone Nov 10, 2023
@imorland imorland merged commit a9756cb into 2.x Nov 10, 2023
22 checks passed
@imorland imorland deleted the sm/dispatch-events-trait branch November 10, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DispatchEventsTrait causes error when event does not have "actor" attribute due to PHP 8.2 deprecation
2 participants