Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(1.x) missing compat exports #3888

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix:(1.x) missing compat exports #3888

merged 1 commit into from
Sep 22, 2023

Conversation

imorland
Copy link
Member

@imorland imorland commented Sep 20, 2023

**Fixes #3887 **

I propose this to form a patch release on 1.8.x, so that the intended functionality is available to extension developers as soon as possible.

Changes proposed in this pull request:
Add the missing exports to compat.

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland requested a review from a team as a code owner September 20, 2023 01:37
@imorland imorland added type/bug javascript Pull requests that update Javascript code type/extensibility labels Sep 20, 2023
@imorland imorland added this to the 1.8.2 milestone Sep 20, 2023
@imorland imorland requested a review from SychO9 September 20, 2023 17:46
@imorland imorland changed the title fix: missing compat exports fix:(1.x) missing compat exports Sep 20, 2023
@imorland imorland merged commit 0d1d4d4 into 1.x Sep 22, 2023
@imorland imorland deleted the im/exports branch September 22, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/bug type/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants