Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export registry #3842

Merged
merged 4 commits into from
Jun 29, 2023
Merged

feat: export registry #3842

merged 4 commits into from
Jun 29, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jun 22, 2023

Fixes #3833

Changes proposed in this pull request:
Please refer to the issue for a detailed plan of the changes introduced here.

  • Compat API has been replaced with simple forum/forum.ts common/common.ts and admin/admin.ts that import all modules so that they are included in the final bundle regardless of i they are used internally or not.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

SychO9 added 4 commits June 21, 2023 10:14
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Registry
2 participants