Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(phpstan): upgrade to be compatible with latest dependency updates #3835

Merged
merged 11 commits into from
Jun 15, 2023
Merged

chore(phpstan): upgrade to be compatible with latest dependency updates #3835

merged 11 commits into from
Jun 15, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jun 15, 2023

Changes proposed in this pull request:
This is one of two PRs to upgrade phpstan (and larastan in the process) to be compatible with the recent php and dependency upgrades.

Now that we have PHP 8.1 as a minimum, a subsequent PR will upgrade the level of analysis to 6+

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

SychO9 and others added 5 commits June 15, 2023 11:44
@SychO9
chore(phpstan): adapt phpstan to upgraded dependencies (laravel 10)
51563d0 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore: use eloquent builder contract
5b99a54 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore: dead code
da8c0f7 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@StyleCIBot
Apply fixes from StyleCI
43eafbb
@SychO9
fix: testcase database instance is null
b6e906b 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner June 15, 2023 12:23
SychO9 added 4 commits June 15, 2023 13:29
@SychO9
fix: test failures
aea859d 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
Merge branch '2.x' into sm/phpstan-upgrade
241dba6 
# Conflicts:
#	php-packages/testing/src/integration/TestCase.php
@SychO9
fix: merge conflicts
940e398 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore: fix phpstan workflow
10773ba 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore: fix phpstan workflow
cad66eb 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 marked this pull request as draft June 15, 2023 12:45
@SychO9
chore: adapt workflows
70eb74a 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 force-pushed the sm/phpstan-upgrade branch from e6b7ace to 70eb74a Compare June 15, 2023 16:37
@SychO9 SychO9 marked this pull request as ready for review June 15, 2023 16:48
@SychO9 SychO9 added this to the 2.0 milestone Jun 15, 2023
@SychO9 SychO9 changed the title chore(phpstan): upgrade to be compatible with latest dependency updates. chore(phpstan): upgrade to be compatible with latest dependency updates Jun 15, 2023
@SychO9 SychO9 added breaking-changes dependencies Pull requests that update a dependency file labels Jun 15, 2023
@SychO9 SychO9 merged commit 493ffa0 into 2.x Jun 15, 2023
@SychO9 SychO9 deleted the sm/phpstan-upgrade branch June 15, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
breaking-changes dependencies Pull requests that update a dependency file type/infrastructure
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@SychO9 @imorland @StyleCIBot