Change README to refer to LLVM_BUILD_DIR. #1033
Conversation
LLVM_INSTALL_TOOLS doesn't seem to install llvm-lit anymore. However pointing to the cmake file in the build directory works fine, and lit and FileCheck will be picked up correctly this way.
|
I've bundled in a fix for #974 to this, as the new build instructions and the fix of those depends need to go hand in hand. |
| llvm-lit | ||
| FileCheck | ||
| count | ||
| not |
There was a problem hiding this comment.
We will want to add these back in once #969 lands, but right now these aren't targets that we can depend on because they're not present as targets in our own cmake call.
|
@sscalpone or @tskeith are you happy to merge this for David? |
|
It looks like these instructions are going to conflict with the ones in PR #1035 which require an LLVM install. |
|
Ok, I think there's a bug here (or more than one) on the LLVM side. Surely either the AddMLIR.cmake file should be in the build directory or llvm-lit should be installed when -DLLVM_INSTALL_UTILS is on. I'm somewhat inclined to say both should be the case personally. Let me investigate why llvm-lit isn't installed when I think it should be (and am sure it used to be) first. |
I agree on both counts.
That sounds good. I think we should assume we should build against an LLVM install, and until this is fixed work around the missing llvm-lit by setting LLVM_EXTERNAL_LIT or manually installing llvm-lit by copying it into the install. |
* Change README to refer to LLVM_BUILD_DIR. LLVM_INSTALL_TOOLS doesn't to install llvm-lit. However pointing to the cmake file in the build directory works fine, and lit and FileCheck will be picked up correctly this way.
…#1033) * Change README to refer to LLVM_BUILD_DIR. LLVM_INSTALL_TOOLS doesn't to install llvm-lit. However pointing to the cmake file in the build directory works fine, and lit and FileCheck will be picked up correctly this way. Original-commit: flang-compiler/f18@3cbe344 Reviewed-on: flang-compiler/f18#1033
…#1033) * Change README to refer to LLVM_BUILD_DIR. LLVM_INSTALL_TOOLS doesn't to install llvm-lit. However pointing to the cmake file in the build directory works fine, and lit and FileCheck will be picked up correctly this way. Original-commit: flang-compiler/f18@3cbe344 Reviewed-on: flang-compiler/f18#1033
LLVM_INSTALL_TOOLS doesn't seem to install llvm-lit anymore. However
pointing to the cmake file in the build directory works fine, and lit
and FileCheck will be picked up correctly this way.