Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add The Japan News #627

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Add The Japan News #627

merged 4 commits into from
Oct 16, 2024

Conversation

addie9800
Copy link
Collaborator

No description provided.

@addie9800 addie9800 requested a review from MaxDall October 13, 2024 14:29
Copy link
Collaborator

@MaxDall MaxDall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding 👍 Maybe we should specify the language a news paper uses at one point, what do you think?

domain="https://japannews.yomiuri.co.jp/",
parser=TheJapanNewsParser,
sources=[
Sitemap("https://japannews.yomiuri.co.jp/sitemap.xml"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of things we should filter from the sitemap, like root, category, etc.

@addie9800 addie9800 requested a review from MaxDall October 16, 2024 20:13
@addie9800 addie9800 merged commit 6174d66 into master Oct 16, 2024
5 checks passed
@addie9800 addie9800 deleted the add-jp branch October 16, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants