Rework Article class
#559
Merged
Rework Article class
#559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addie9800
requested changes
Jul 17, 2024
|
|
||
| def __getattribute__(self, item: str): | ||
| if (attribute := object.__getattribute__(self, item)) and hasattr(attribute, "__get__"): | ||
| return attribute.__get__(self, type(self)) |
There was a problem hiding this comment.
When does this case come into play? I tried playing around a bit, but didn't find a setting where it is used.
There was a problem hiding this comment.
Every unvalidated attribute, more precise, every attribute that is added as AttributeView rather than a property is accessed this way.
You can see this in action in the test_extraction_view_getter test case.
addie9800
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhaul of Article Class with Enhanced Data Management
Overview
This PR presents a comprehensive overhaul of the Article class to improve data handling and maintainability.
Key Changes
Introduction of Data Views: The refactor emphasizes maintaining raw extraction data as the primary source while providing structured
Viewsfor data access. This approach facilitates easier benchmarking and evaluation.Implementation of Custom Attribute Handling: Custom
__getattribute__and__setattr__methods replicate Descriptor-like behavior, ensuring controlled attribute access without relying on class attributes.Read-Only Attributes: Initially, all extraction data is read-only to enhance security and stability. This simplifies data integrity management, with provisions for future writable features.
This PR serves as preparation for the upcoming CC-NEWS benchmark!