Rework logging and fix overwritten config #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addie9800
requested changes
Jul 4, 2024
addie9800
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug when using
spawnas start method for multiprocessingPreviously, when using
spawnas a start method, already set logging configurations are overwritten, when starting a new process. This PR introduces a workaround, passing the current configuration to thePooland initializing the logging module with said config when a new process is started for theCCNewsCrawler.Reworks parts of the logging module
IMO adding handlers and setting levels was still pretty tedious, even after the last rework. With this PR, the logger debug level is set to
DEBUGby default, and one controls debugging with handler levels instead of the logger level.