Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require at least one paragraph to evaluate ArticleBody to true #500

Merged
merged 2 commits into from
May 2, 2024
Merged

Require at least one paragraph to evaluate ArticleBody to true #500

merged 2 commits into from
May 2, 2024

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Apr 30, 2024 •
edited
Loading

This PR requires ArticleSection and ArticleBody respectively to consist of at least one paragraph to be evaluated as True. This is to increase the data quality of retrieved articles.

I had to replace an old WAZ test case which consisted of only a summary.

@MaxDall MaxDall requested a review from dobbersc April 30, 2024 14:24
dobbersc
dobbersc approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@dobbersc dobbersc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@MaxDall MaxDall merged commit e50ef12 into master May 2, 2024
4 checks passed
@MaxDall MaxDall deleted the require-at-least-one-paragraph branch May 2, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobbersc dobbersc dobbersc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDall @dobbersc