Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable strict_query parsing for URL validation. #407

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Apr 10, 2024

As with the recent changes regarding the validators package, URLs like this https://www.lrt.lt/?rss are now rendered invalid.

Although there is already an issue addressing this within cpython, it doesn't seem like this is gonna be resolved soon so this PR basically disables query validation for URLs.

@MaxDall MaxDall changed the base branch from master to unbatch-fundus April 10, 2024 09:57
@MaxDall MaxDall requested a review from addie9800 April 10, 2024 16:42
addie9800
addie9800 previously approved these changes Apr 12, 2024
Base automatically changed from unbatch-fundus to master April 18, 2024 10:28
@MaxDall MaxDall dismissed addie9800’s stale review April 18, 2024 10:28

The base branch was changed.

@MaxDall MaxDall merged commit 2395eb1 into master Apr 18, 2024
4 checks passed
@MaxDall MaxDall deleted the set-strict-parsing-false branch April 18, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants