Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] A parser for the titanic #185

Closed
wants to merge 3 commits into from
Closed

[WIP] A parser for the titanic #185

wants to merge 3 commits into from

Conversation

Weyaaron
Copy link
Collaborator

@Weyaaron Weyaaron commented May 8, 2023

This one has several open problems at the moment, but I wanted to get it out to enable cooperation and comments.
Any of these issues is up for grab, just overwrite the code and mark it as solved.

  • There is an issue with XPath, specifically with the summary. I have trouble extracting it. There is a comment in the code about it.
  • Should we include this parser at all? Since it is all about satire, it might mess with the intention to download news.
  • There are few articles, maybe Adds a mechanism for accepting or rejecting articles  #184 should be used on this one.

# Conflicts:
#	src/fundus/publishers/de/__init__.py
#	src/fundus/publishers/de/titanic_parser.py
@Weyaaron
Copy link
Collaborator Author

Weyaaron commented May 8, 2023

Until some of these kinks have been iron out, there is no need to worry about the ci.

@Weyaaron
Copy link
Collaborator Author

This PR is really low priority and may be redone once other more important tasks have been completed.

@Weyaaron Weyaaron closed this Jul 12, 2023
@MaxDall MaxDall deleted the parser_titanic branch July 17, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant