Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework AutoPipeline #101

Merged
merged 12 commits into from
Mar 20, 2023
Merged

Rework AutoPipeline #101

merged 12 commits into from
Mar 20, 2023

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Mar 16, 2023 •
edited
Loading

This reworks the former class AutoPipeline by:

  • Renaming the class to Crawler
  • move the pipeline part in a separate class called Pipeline which is still accessible

This also does:

  • reduce import length for Crawler and PublisherCollection by exporting them at root
  • Rename former Crawler class to Source

This also adds test cases for the Collection/PublisherCollection as well as for the Pipeline. I did so to test the rework properly and didn't want to open a separate PR.

@MaxDall MaxDall mentioned this pull request Mar 16, 2023
Closed
2 tasks
@MaxDall MaxDall added the rework Reworks parts of the project label Mar 19, 2023
@MaxDall MaxDall mentioned this pull request Mar 19, 2023
Merged
@MaxDall MaxDall mentioned this pull request Mar 20, 2023
Open
4 tasks
@MaxDall MaxDall merged commit d949844 into master Mar 20, 2023
@MaxDall MaxDall deleted the rework_autopipeline branch March 20, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rework Reworks parts of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MaxDall