Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shiven Garia #71789

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

Shiven0504
Copy link
Contributor

No description provided.

@github-actions
Copy link

Thank you for your pull request. This pull request contains changes in files which requires review. The following files were changed:

  • Contributors.md
  • gui-tool-tutorials/github-windows-intellij-tutorial.md

@Esh07
Copy link
Contributor

Esh07 commented Aug 18, 2023

Hey @Shiven0504 thank you for submitting PR.

Your changes to Contributors.md are fine and mergeable.

However, the changes you made in the other file are not correct and accurate. For example, "IntelliJ" is the correct way of writing it, and for other changes, the word is a noun in the terminology of Git.

Therefore, the changes you proposed do not justify the enhancement.

Could you please remove those changes?

Cheers,
Esh

Copy link
Contributor

@Esh07 Esh07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changes from github-windows-intellij-tutorial.md.

@Roshanjossey Roshanjossey merged commit a9fe1c7 into firstcontributions:main Aug 23, 2023
@Roshanjossey
Copy link
Member

Hello, congratulations! You've successfully submitted a pull request. 🎉

If you liked the tutorial, please star this repo by clicking the star button on the top right of this page. star screenshot

Next steps

We'd love to hear your thoughts about this project. Let us know how we can improve by commenting or opening an issue here.

celebration gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants