-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] App crashes after opening for a second time #1160
Comments
Same for me |
(drive-by comment) The stack trace points to the exception originating at the The stack trace shows that the crash is happening during Here is the line of code that is crashing, in So it appears that the We had to fix a similar situation in Firestore to avoid crashes caused by the same sort of boundary condition: firebase/firebase-cpp-sdk#585. The logic is somewhat buried in that commit since Firestore created this "promise" layer to try to shelter the rest of Firestore from the details of |
Removing the bug tag until we can reproduce this internally. |
@dconeybe |
@nhhuynh Apologies for the confusion. My comment was not directed at you, but rather directed at other Firebase developers who end up investigating this issue. It piqued my interest so I added my thoughts in the comments but my expertise lies elsewhere in Firebase. Those classes that I mentioned are internal implementation details of the Firebase C++ SDK (which is used under the hood by the Firebase Unity SDK). |
I tried to create an internal reproduction of this issue by deleting the Firebase App in the Messaging Quickstart Testapp but I couldn't reproduce this issue. Could you provide more details about what your app is doing on startup that might cause the second instance to teardown the Firebase APP object? Even better, could you provide us with a reproducible test case? Thanks! |
Hi @DellaBitta |
I am also having the same problem. |
Hi @DellaBitta
|
Our team have the same issue. Hope it will be fixed soon |
@DellaBitta Future with handle 1 still exists though its backing API 0xA01F2480 is being deleted. Please call Future::Release() before deleting the backing API. What could be a possible cause for this? |
@nhhuynh Based on your description, it sounds like something was trying to delete FirebaseApp ( Possible issue 1I remember there was an old issue in Unity 2018 that the application did not delete the previously created after quitting. The quick workaround is to make sure
I suspect this may not be related, or there should be a bug reporting from Unity about this regression. But worth trying. Possible issue 2Another possible reason why an FirebaseApp is deleted at this odd time is that However, Firebase SDK does try to destroy the future data here. Also, if this were the issue, you should experience the crash for the first launch already. Questions for @nhhuynh
Question for @PBW99 and @yanmasharskiCould you tell us more about your configuration (like Firebase version, installed Firebase packages, Unity versions, etc)? |
Thank you for the info! I noticed that you call As I mentioned, when Could you try to remove Thank you for the info. I think the capability to receive push notification is specified in Could you confirm if you are NOT calling Interestingly, there is a patch in Thank you for the info. Could you confirm if you are NOT calling |
Thanks for the explanation, I was not aware of that. I thought that it's the FirebaseMessaging SDK that handles the push notifications all the way through. Regarding your question, I can confirm that I'm not calling it twice, my implementation is quite straightforward:
And that's the only code that uses any of the Firebase API in my game. Previously I was on Firebase 7.1.0 and the above was working just fine. I've upgraded to 8.2.0 and this issue started happening, tried both 8.3.0 and 8.4.0 but with no luck - issue still persists. |
Hello, I found the same (?) issue in our Google Play console, but it only happened to one of ours users, and I had to filter the crashes so that it shows installs from unknown sources aswell.
Here is my code:
|
Thanks @chkuang-g! Removing excess CheckAndFixDependencies calls worked for me! |
I'm getting the same crash and can confirm I am only calling CheckAndFixDependencies a single time. This issue only occurs for some users, but it occurs to those users constantly. Unfortunately one of those users is not myself.
Edit2: Nevermind, only some users I've created an issue here, might be duplicate (although it does contain useful information) |
I upgraded from 8.1.0 to 8.4.0, so it would seem like an issue introduced in 8.2.0 |
I can confirm that it started happening again when I upgraded to Firebase version 8.3.0. It was working on 8.1.0 |
Strongly suspect this is also a dupe of #1170. It seems this issue is fairly widespread. |
Hopefully some of these are fixed in firebase/firebase-cpp-sdk#739 |
Hi folks, The crash described in this thread seems to have the following in-common:
If this fits your profile, I think this issue should be fixed by firebase/firebase-cpp-sdk#739, and included in Firebase @nhhuynh Could you verify if this works for you? For those who does not fit the profile, please take a look of other thread Thank you |
@chkuang-g We are getting the issue with Firebase sdk 8.6.1 too. Its not coming always but like 20% user impacted. Upgraded from firebase 7.2.0. Unity version: 2019.4.30f1 pthread_mutex_lock.txt |
@chkuang-g same issue with Firebase sdk 8.6.1. Any updates? |
@chkuang-g |
We haven't been able to completely reproduce the problem on our end, but we just released 8.6.2, which contains a potential fix for the issue. |
Hey @nhhuynh. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically. If you have more information that will help us get to the bottom of this, just add a comment! |
Since there haven't been any recent updates here, I am going to close this issue. @nhhuynh if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this. |
[REQUIRED] Please fill in the following fields:
[REQUIRED] Please describe the issue here:
(Please list the full steps to reproduce the issue. Include device logs, Unity logs, and stack traces if available.)
Steps to reproduce:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
What's the issue repro rate? (eg 100%, 1/5 etc)
I have not been able to reproduce the issue in firebase quickstart.
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
App crashes after second instance it is opened
Stack trace log:
The text was updated successfully, but these errors were encountered: