Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up Core Internal for SPM #9298

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Set up Core Internal for SPM #9298

merged 1 commit into from
Feb 7, 2022

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Feb 4, 2022 •
edited
Loading

Alternative to #9292 that moves the Core Internal files instead of copying them

This should work for SwiftPM. CocoaPods is resolved in #9300.

#no-changelog

@paulb777 paulb777 requested a review from ryanwilson February 7, 2022 14:59
ryanwilson
ryanwilson approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small questions but LGTM, thanks!

FirebaseCore/Internal/FirebaseCoreInternal.h Show resolved Hide resolved
Package.swift Show resolved Hide resolved
Base automatically changed from pb-func-unit-tests1 to functions-swift-main February 7, 2022 17:37
@paulb777 paulb777 merged commit 799726d into functions-swift-main Feb 7, 2022
@paulb777 paulb777 deleted the pb-core-internal branch February 7, 2022 17:42
@paulb777 paulb777 mentioned this pull request Feb 8, 2022
Closed
3 tasks
paulb777 added a commit that referenced this pull request Feb 12, 2022
@paulb777
Set up Core Internal for SPM (#9298)
0497cc8
paulb777 added a commit that referenced this pull request Mar 3, 2022
@paulb777
Set up Core Internal for SPM (#9298)
854bec1
paulb777 added a commit that referenced this pull request Mar 4, 2022
@paulb777
Set up Core Internal for SPM (#9298)
a07ca13
@firebase firebase locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
api: appcheck api: appdistribution api: auth api: core api: crashlytics api: database api: dynamiclinks api: firestore api: functions api: inappmessaging Firebase In App Messaging api: installations api: messaging api: performance api: remoteconfig api: storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @ryanwilson @google-oss-bot