Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated elements of FIAM API #6617

Merged
merged 11 commits into from
Oct 1, 2020
Merged

Remove deprecated elements of FIAM API #6617

merged 11 commits into from
Oct 1, 2020

Conversation

christibbs
Copy link
Contributor

Removes deprecated message initializers and one deprecated message lifecycle callback.

Fixes #6545.

@christibbs christibbs added this to the Firebase 7 milestone Sep 30, 2020
@google-cla google-cla bot added the cla: yes label Sep 30, 2020
@firebase firebase deleted a comment from google-oss-bot Sep 30, 2020
paulb777
paulb777 reviewed Sep 30, 2020
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports need to be repo-relative to work across package managers.

See https://github.com/firebase/firebase-ios-sdk/blob/master/HeadersImports.md

@christibbs
Revert "Fix imports"
1e42c9d 
This reverts commit 55fdbbd.
@christibbs
Copy link
Contributor Author

Imports need to be repo-relative to work across package managers.

See https://github.com/firebase/firebase-ios-sdk/blob/master/HeadersImports.md

Done in 1e42c9d. Strangely enough this builds locally for my pod gen unit tests and my UI tests, but not for the end-to-end tests (even though the Podfile for end-to-end tests is nearly identical to the one for UI tests).

paulb777
paulb777 approved these changes Oct 1, 2020
View reviewed changes
FirebaseInAppMessaging/CHANGELOG.md
@@ -1,3 +1,6 @@
# 2020-10 -- v7.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the version will likely be v7.0.0-beta - I still have more research to do on managing betas after 7.0.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulb777 Alright. I'll change this if necessary.

@christibbs christibbs changed the title [DO NOT MERGE UNTIL FIREBASE 7] Remove deprecated elements of FIAM API Remove deprecated elements of FIAM API Oct 1, 2020
@christibbs christibbs merged commit 00a3021 into master Oct 1, 2020
@christibbs christibbs deleted the fiam-remove-deprecations branch October 1, 2020 20:01
@firebase firebase locked and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

Assignees
No one assigned
Labels
api: inappmessaging Firebase In App Messaging cla: yes public-api-change
Projects
None yet
Milestone
Firebase 7 - M82
Development

Successfully merging this pull request may close these issues.

FIAM: Remove deprecated APIs
3 participants
@christibbs @paulb777 @google-oss-bot