Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SPM analytics warning introduced yesterday #6504

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Fix SPM analytics warning introduced yesterday #6504

merged 2 commits into from
Sep 21, 2020
+36 −3

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Sep 19, 2020 •
edited
Loading

Fix #6503

Adds a dummy header so the SPM-generated umbrella won't give a warning.
Fixes copyrights in FirebaseAnalyticsWrapper directory.

Disregard the CI failure since the failing test is pending the 6.33.0 CocoaPods publish.

#no-changelog

@paulb777 paulb777 requested a review from ryanwilson September 19, 2020 16:19
@paulb777 paulb777 merged commit 31b43e5 into 6.33-spm-beta Sep 21, 2020
@paulb777 paulb777 deleted the pb-spm-warning-fix branch September 21, 2020 14:17
paulb777 added a commit that referenced this pull request Sep 23, 2020
@paulb777
Merge 6.33 SPM fixes back to master (#6530)
1d1ae87 
* SPM M80(6.33.0) Analytics update (#6490)
* Remove unnecessary analytics public header copy (#6498)
* Fix SPM analytics warning introduced yesterday (#6504)
* Fix SPM version (#6527)
christibbs pushed a commit that referenced this pull request Sep 28, 2020
@paulb777 @christibbs
Merge 6.33 SPM fixes back to master (#6530)
b630836 
* SPM M80(6.33.0) Analytics update (#6490)
* Remove unnecessary analytics public header copy (#6498)
* Fix SPM analytics warning introduced yesterday (#6504)
* Fix SPM version (#6527)
@firebase firebase locked and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @ryanwilson @googlebot