Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashlytics AW Sigaction crash fix #6434 #6436

Merged
merged 10 commits into from
Sep 15, 2020
Merged

Crashlytics AW Sigaction crash fix #6434 #6436

merged 10 commits into from
Sep 15, 2020

Conversation

jostster
Copy link
Contributor

@jostster jostster commented Sep 10, 2020 •
edited by paulb777
Loading

This fixes the crashlytics crash on apple watch, which doesn't support sigaction. Fix #6434

@paulb777
Copy link
Member

Thanks for the fix! Please fix the CI failures and add a note to https://github.com/firebase/firebase-ios-sdk/blob/master/Crashlytics/CHANGELOG.md.

@jostster
Copy link
Contributor Author

@paulb777 looks like there might be an issue with execution policy for tvos? Not able to see the details of why it is failing.

@paulb777
Copy link
Member

@jostster Running scripts/pod_lib_lint.rb FirebaseCrashlytics.podspec --platforms=tvos --verbose in your branch shows

    Undefined symbols for architecture x86_64:
      "_FIRCLSSignalInitialize", referenced from:
          ___FIRCLSContextInitialize_block_invoke_2.29 in FirebaseCrashlytics(FIRCLSContext.o)
      "_FIRCLSSignalCheckHandlers", referenced from:
          ___52-[FIRCLSReportManager crashReportingSetupCompleted:]_block_invoke in FirebaseCrashlytics(FIRCLSReportManager.o)
    ld: symbol(s) not found for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)


    Test session results, code coverage, and logs:
    	/Users/paulbeusterien/Library/Developer/Xcode/DerivedData/App-etocetmlokomdlfjvqpeqfycrpbt/Logs/Test/Run-FirebaseCrashlytics-Unit-unit-2020.09.10_10-22-02--0700.xcresult

    Testing failed:
    	Undefined symbol: _FIRCLSSignalInitialize
    	Undefined symbol: _FIRCLSSignalCheckHandlers
    	Testing cancelled because the build failed.

It looks like #if adjustments are needed.

paulb777
paulb777 reviewed Sep 10, 2020
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jostster! LGTM

Assigning to the Crashlytics team for review and approval.

@paulb777 paulb777 added this to the 6.33.0 - М80 milestone Sep 10, 2020
samedson
samedson approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one ask for a comment - LGTM! 🚢

@jostster
Update FIRCLSFeatures.h
2eef6e6 
Added comment for signal support
@jostster
Copy link
Contributor Author

Comment added per review

@samedson
Copy link
Contributor

Should be good to merge when you're ready @jostster 👍

@jostster
Copy link
Contributor Author

@samedson I don't have write access so cannot merge.

@samedson
Copy link
Contributor

Woops alright I got you!

@samedson samedson merged commit 1f42845 into firebase:master Sep 15, 2020
@markvasiv markvasiv mentioned this pull request Oct 6, 2020
Closed
@firebase firebase locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 left review comments

@samedson samedson samedson approved these changes

Assignees

@samedson samedson

Labels
api: crashlytics cla: yes watchOS
Projects
None yet
Milestone
6.33.0 - М80
Development

Successfully merging this pull request may close these issues.

Crashlytics crashes in WatchOS with sigaction on fatal signals is not supported
4 participants
@jostster @paulb777 @samedson @googlebot