Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix public method names. #4666

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Fix public method names. #4666

merged 1 commit into from
Jan 13, 2020

Conversation

ryanwilson
Copy link
Member

@ryanwilson ryanwilson commented Jan 13, 2020 •
edited
Loading

s/<SDK>WithApp/<SDK>ForApp/g

Note: this doesn't affect initWithApp: since that's an internal method.

#no-changelog

@ryanwilson
Fix public method names.
4408181 
`s/<SDK>WithApp/<SDK>ForApp/g`

Note: this doesn't affect `initWithApp:` since that's an internal method.
@ryanwilson ryanwilson requested a review from paulb777 January 13, 2020 14:46
@ryanwilson ryanwilson mentioned this pull request Jan 13, 2020
Closed
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ryanwilson ryanwilson merged commit 2ffc2f3 into master Jan 13, 2020
@ryanwilson ryanwilson deleted the rw-interop-docs branch January 13, 2020 15:18
@firebase firebase locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanwilson @google-oss-bot @paulb777 @googlebot