Add travis check for filename spaces #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
reviewed
Apr 12, 2019
scripts/check_filename_spaces.sh
Outdated
| ! -path './Interop/Firebase Component System.md' | ||
| ) | ||
|
|
||
| result=`find . -name "* *" "${options[@]}"` |
There was a problem hiding this comment.
This approach will fail if there are too many files with spaces in them.
It also fails when editors create filenames with spaces, which Xcode, CMake, and CLion do regularly e.g. for temporary testing schemes. Committing this as-is would make local runs of check.sh impossible.
It may be possible to combine this with what git considers ignored to alleviate the second concern. Let me see if I can figure it out.
There was a problem hiding this comment.
Thanks. Using only files git knows about also enables reducing the skip list.
scripts/check_filename_spaces.sh
Outdated
| ! -path '*/Assets.xcassets/*' | ||
| ! -path '*/Target Support Files' | ||
| ! -path '*/Local Podspecs' | ||
| ! -path './Interop/Firebase Component System.md' |
There was a problem hiding this comment.
Why not rename this file rather than grandfather it?
wilhuff
approved these changes
Apr 12, 2019
scripts/check_filename_spaces.sh
Outdated
| # Xcode-generated asset files | ||
| /Assets.xcassets/ d | ||
|
|
||
| # Grandfathered files |
There was a problem hiding this comment.
No files are grandfathered. Consider removing.
Corrob
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Proposed improvements to space checking (#2824)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2223
Spaces in filenames cause problems with style.sh, bazel Swift rules, the command line, and potentially other scripts.
By default, ensure that new files with spaces don't get added to the repo.