Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CoreInternal] Add async flush method #13850

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[CoreInternal] Add async flush method #13850

merged 2 commits into from
Oct 8, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Oct 8, 2024

#no-changelog

@ncooke3 ncooke3 requested a review from paulb777 October 8, 2024 20:58
paulb777
paulb777 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will you update clients in a separate PR?

@ncooke3 ncooke3 merged commit 78f970b into main Oct 8, 2024
62 checks passed
@ncooke3 ncooke3 deleted the nc/core-async branch October 8, 2024 21:26
@ncooke3 ncooke3 mentioned this pull request Oct 8, 2024
Merged
MojtabaHs pushed a commit to MojtabaHs/firebase-ios-sdk that referenced this pull request Oct 17, 2024
@ncooke3 @MojtabaHs
[CoreInternal] Add async flush method (firebase#13850)
f0f2c87
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @paulb777 @google-oss-bot