Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-app fix #10805

Merged
merged 12 commits into from
Feb 10, 2023
Merged

Multi-app fix #10805

merged 12 commits into from
Feb 10, 2023

Conversation

renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Feb 9, 2023 •
edited by paulb777
Loading

Pass auth instance in request configure and use it to:

  1. retrieve the associated tenant ID for requests User is created in a specific tenant although tenantID was not specified  #10748
  2. store the associated auth instance in MFA resolver [auth] The resolver exposed in MFA is not associated to the correct app #10690

Fix #10748
Fix #10690

@renkelvin renkelvin requested a review from paulb777 February 10, 2023 00:46
paulb777
paulb777 reviewed Feb 10, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Is it feasible to add a regression test for the MultiFactor issue?

Would you update the Changelog?

FirebaseAuth/Tests/Unit/FIRIdentityToolkitRequestTests.m Outdated Show resolved Hide resolved
@renkelvin
Copy link
Contributor Author

Looks good. Thanks!

Is it feasible to add a regression test for the MultiFactor issue?

Would you update the Changelog?

Good suggestions. Done.

@paulb777 paulb777 added this to the 10.6.0 - M128 milestone Feb 10, 2023
@renkelvin renkelvin merged commit 0216c1a into master Feb 10, 2023
@renkelvin renkelvin deleted the multi-app branch February 10, 2023 22:01
paulb777 added a commit that referenced this pull request Feb 11, 2023
@paulb777
Post rebase updates for #10805 and #10441
b31f574
paulb777 added a commit that referenced this pull request Feb 24, 2023
@paulb777
Post rebase updates for #10805 and #10441
f01fc51
paulb777 added a commit that referenced this pull request Mar 3, 2023
@paulb777
Post rebase updates for #10805 and #10441
01071da
paulb777 added a commit that referenced this pull request Mar 7, 2023
@paulb777
Post rebase updates for #10805 and #10441
29f8716
@firebase firebase locked and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
10.6.0 - M128
3 participants
@renkelvin @paulb777 @google-oss-bot