Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Re-write API docs for COUNT API #10258

Merged
merged 8 commits into from
Sep 27, 2022
Merged

Firestore: Re-write API docs for COUNT API #10258

merged 8 commits into from
Sep 27, 2022

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Sep 24, 2022 •
edited
Loading

The wording is copied from firebase/firebase-android-sdk#4143

#no-changelog

@dconeybe dconeybe self-assigned this Sep 24, 2022
@dconeybe dconeybe requested a review from wu-hui September 27, 2022 05:37
@dconeybe dconeybe marked this pull request as ready for review September 27, 2022 15:12
@dconeybe dconeybe changed the title Firestore: Re-write API javadocs for COUNT API Firestore: Re-write API docs for COUNT API Sep 27, 2022
wu-hui
wu-hui approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have good suggestions, but I think some of the comments can be more concise. Maybe we should run this by a tech writer too.

@dconeybe
Copy link
Contributor Author

I don't have good suggestions, but I think some of the comments can be more concise. Maybe we should run this by a tech writer too.

Thanks for the feedback. I do tend to be kind of wordy. I'll engage a tech writer for review, but I'll merge this for now.

@dconeybe dconeybe merged commit 1478d9c into revert-10252-revert-10246-wuandy/PublicCount Sep 27, 2022
@dconeybe dconeybe deleted the dconeybe/CountApiDocs branch September 27, 2022 16:09
ehsannas added a commit that referenced this pull request Sep 28, 2022
@wu-hui @dconeybe @ehsannas
Public count (#10254)
4232ac1 
* Revert "Revert "Public count (#10246)" (#10252)"

This reverts commit b695d99.

* Firestore: Re-write API docs for COUNT API (#10258)

* Add isEqual and hash for aggregate classes (#10261)

Co-authored-by: Denver Coneybeare <dconeybe@google.com>
Co-authored-by: Ehsan <ehsannas@gmail.com>
@firebase firebase locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

@dconeybe dconeybe

Labels
api: firestore public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @wu-hui @google-oss-bot