Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firebase 10] Bump versions for 10.0.0 #10244

Merged
merged 29 commits into from
Sep 24, 2022
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Sep 21, 2022

Context

  • Bumped all Firebase products to 10.0.0
  • Bumped dependencies on GTMSessionFetcher to min 2.1
  • Bumped dependencies on GoogleUtilities to 7.8
  • Bumped dependencies on GoogleDataTransport to 9.2

Follow-up tasks from #10233

  • Bumped tvOS min. support from 11.0 to 12.0
  • Bumped AppCheck's min. support for iOS from 10.0 to 11.0

FirebaseAnalytics.podspec Outdated Show resolved Hide resolved
FirebaseCrashlytics.podspec Outdated Show resolved Hide resolved
FirebaseInAppMessaging.podspec Outdated Show resolved Hide resolved
FirebaseMessaging.podspec Outdated Show resolved Hide resolved
FirebasePerformance.podspec Outdated Show resolved Hide resolved
@ncooke3 ncooke3 closed this Sep 21, 2022
@ncooke3 ncooke3 reopened this Sep 21, 2022
@ncooke3 ncooke3 added this to the Firebase 10 - M122 milestone Sep 21, 2022
@google-oss-bot

This comment was marked as off-topic.

Gemfile Outdated Show resolved Hide resolved
@google-oss-bot

This comment was marked as off-topic.

@ncooke3

This comment was marked as outdated.

Firebase.podspec Outdated Show resolved Hide resolved
Firebase.podspec Outdated Show resolved Hide resolved
@ncooke3
Copy link
Member Author

ncooke3 commented Sep 23, 2022

auth / pod-lib-lint (tvos) had a failure from raising the minimum supported tvOS version. It looks due to a deprecation warning that was new in tvOS 12.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI except for FirebaseUI caused failures

@ncooke3
Copy link
Member Author

ncooke3 commented Sep 23, 2022

auth / pod-lib-lint (tvos) had a failure from raising the minimum supported tvOS version. It looks due to a deprecation warning that was new in tvOS 12.

Fixed in abaa752

@morganchen12
Copy link
Contributor

FirebaseUI release in progress (firebase/FirebaseUI-iOS#1100), might punt to Monday

@ncooke3
Copy link
Member Author

ncooke3 commented Sep 24, 2022

There were some issues that arose from bumping tvOS to 12.

  • On green CI, squash the tvOS commits down to one in case we want to undo bumping to tvOS 12

@ncooke3
Copy link
Member Author

ncooke3 commented Sep 24, 2022

Ok, as of 91c7dbe, all CI is passing except for expected FirebaseUI failure.

Going to send two more commits:

  • one to squash all of the tvOS 12 commits into one
  • one to revert Gemfile

@ncooke3 ncooke3 force-pushed the nc/firebase10-version-updates branch from 91c7dbe to 491481d Compare September 24, 2022 11:05
@ncooke3 ncooke3 merged commit af1201c into master Sep 24, 2022
@ncooke3 ncooke3 deleted the nc/firebase10-version-updates branch September 24, 2022 11:06
@ncooke3
Copy link
Member Author

ncooke3 commented Sep 24, 2022

Ok, as of 91c7dbe, all CI is passing except for expected FirebaseUI failure.

Going to send two more commits:

  • one to squash all of the tvOS 12 commits into one
  • one to revert Gemfile

I ultimately wanted one commit for all the tvOS changes in case we needed to revert in the future. Since all PR commits are squashed into master, I'm not sure if the squash tvOS commit could be singly reverted anyway... Anyhow, in messing with the commit history, 91c7dbe no longer exists. But the tests did pass at that point and there was no extra diff (apart from reverted Gemfile) when I submitted. So, should be good here.

@morganchen12
Copy link
Contributor

FirebaseUI's been pushed, tests should pass now.

@ncooke3
Copy link
Member Author

ncooke3 commented Sep 26, 2022

thank you @morganchen12!

@firebase firebase locked and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.