-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Firebase 10] Bump versions for 10.0.0 #10244
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green CI except for FirebaseUI caused failures
FirebaseUI release in progress (firebase/FirebaseUI-iOS#1100), might punt to Monday |
There were some issues that arose from bumping tvOS to 12.
|
Ok, as of 91c7dbe, all CI is passing except for expected FirebaseUI failure. Going to send two more commits:
|
Adding new 1p domain "app.google" support in FDL SDK.
* Public Count * Swift Test Commit * Swift Format * No extra whitespace * Hopefully formatted. * Change log and feedback.
91c7dbe
to
491481d
Compare
I ultimately wanted one commit for all the tvOS changes in case we needed to revert in the future. Since all PR commits are squashed into |
FirebaseUI's been pushed, tests should pass now. |
thank you @morganchen12! |
Context
Follow-up tasks from #10233