Lp contrib/waltz 6916 application kind adds #6921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL41
changed the title
|
Added some comments to the issue... |
…/github.com/LeadingPointDev/waltz into lp-contrib/waltz-6916-application-kind-adds
|
@davidwatkins73 revised to just adding 'UNKNOWN'. I'm happy to leave it at just this additional, and then we can coordinate better alternatives for additional options here, such as using the enum table and/or assessments packaged and reviewed: |
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6916
Regrouped applicationKind and added 4 new types to reflect potential use cases: 'Internal Facing' 'External Facing' 'Internal and External Facing' 'Unknown'
