Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: change maven dependencies so Intellij can resolve them correctly #4925

Closed
davidwatkins73 opened this issue Jun 5, 2020 · 0 comments
Closed

Build: change maven dependencies so Intellij can resolve them correctly #4925

davidwatkins73 opened this issue Jun 5, 2020 · 0 comments
Assignees
@davidwatkins73
Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing task Not directly feature related (i.e. dependency upgrade, docs, etc)

Comments

@davidwatkins73
Copy link
Member

Intellij has a problem importing the Waltz project as it fails to resolve dependencies whose values are interpolated by settings in the select profile.

From experimentation it seems that this can be fixed by moving the entire dependency declaration into the profile.
@davidwatkins73 davidwatkins73 added the task Not directly feature related (i.e. dependency upgrade, docs, etc) label Jun 5, 2020
@davidwatkins73 davidwatkins73 self-assigned this Jun 5, 2020
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 5, 2020
@davidwatkins73
Moving vendor specific dependencies into profiles
f72c18f 
- seems to fix the intellij import problem

finos#4925
@davidwatkins73 davidwatkins73 mentioned this issue Jun 5, 2020
Merged
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 5, 2020
@davidwatkins73
Moving vendor specific dependencies into profiles
049c765 
- seems to fix the intellij import problem

finos#4925
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 5, 2020
@davidwatkins73
Moving vendor specific dependencies into profiles
71df324 
- seems to fix the intellij import problem

finos#4925
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 5, 2020
@davidwatkins73
Moving vendor specific dependencies into profiles
c80425c 
- seems to fix the intellij import problem

finos#4925
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 5, 2020
@davidwatkins73
Moving vendor specific dependencies into profiles
f01ae47 
- seems to fix the intellij import problem

finos#4925
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 5, 2020
@davidwatkins73
Moving vendor specific dependencies into profiles
08af9ae 
- seems to fix the intellij import problem

finos#4925
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 5, 2020
@davidwatkins73
Moving vendor specific dependencies into profiles
162ca86 
- seems to fix the intellij import problem

finos#4925
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 8, 2020
@davidwatkins73
Moving vendor specific dependencies into profiles
fcfd203 
Reverting to earlier version of h2 as `UNKNOWN` is now a
reserved word and causes build to fail.

finos#4925
@davidwatkins73 davidwatkins73 added the fixed (test & close) An issue has been fixed, merged into master and is ready for further testing label Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwatkins73 davidwatkins73

Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing task Not directly feature related (i.e. dependency upgrade, docs, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidwatkins73