Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locally-Persisted Filters #768

Merged
merged 6 commits into from
Jul 3, 2023
Merged

Locally-Persisted Filters #768

merged 6 commits into from
Jul 3, 2023

Conversation

jjgry
Copy link
Contributor

@jjgry jjgry commented Jun 16, 2023

This PR addresses issue #403

Features:

Local persisting of filters via new useFilterConfig hook

  • Access previously saved filters and save new filters
  • Hook is accessible from any Vuu component
  • Locally persisted filters are stored using a /api/vuu/filters/{filterId} namespacing.
  • Adds dependency for uuid for generating unique IDs for filters

Basic example of usage set up in the showcase

  1. Enter filter as usual in filter input image
  2. Click on 'save current filter'
  3. (Optional) Clear the current filter, refresh the page, etc
  4. Select a previously saved filter from the dropdown image

@netlify
Copy link

netlify bot commented Jun 16, 2023 •
edited
Loading

✅ Deploy Preview for papaya-valkyrie-395400 canceled.

Name Link
🔨 Latest commit d327cae
🔍 Latest deploy log https://app.netlify.com/sites/papaya-valkyrie-395400/deploys/648c4824ebe7800008db1332

hyhydev
hyhydev approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@hyhydev hyhydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks pretty sensible to me from a general view

@heswell heswell merged commit a93358e into finos:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyhydev hyhydev hyhydev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjgry @hyhydev @heswell