1203 add config option to disable ssl #1255
Conversation
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
junaidzm13
force-pushed
the
1203-add-config-option-to-disable-ssl
branch
from
9f4a317 to
9874c1d
Compare
junaidzm13
force-pushed
the
1203-add-config-option-to-disable-ssl
branch
4 times, most recently
from
c09506f to
04b4c97
Compare
|
|
||
| val config = VuuServerConfig( | ||
| VuuHttp2ServerOptions() | ||
| //only specify webroot if we want to load the source locally, we'll load it from the jar | ||
| //otherwise | ||
| .withWebRoot(webRoot) | ||
| .withSsl(certPath, keyPath) | ||
| .withSsl(sslEnabled, certPath, keyPath) |
There was a problem hiding this comment.
Would it be possible to not call this method at all, or indeed call .withUnencryptedWs()?
It looks a bit odd calling withSsl, passing in certs, but not using them....
There was a problem hiding this comment.
Decided to not call this when ssl is disabled. Can always add another method to do withUnencryptedWs or withoutWss if/when needed. Let me know what you think
There was a problem hiding this comment.
Ok, that is fine to get this over the line. Can we add another ticket to make opting out of Ssl explicit pls?
The reason I say is if you don't have to choose explicitly one or the other, we may well find lots of poeple deploying unencrypted websockets or http connections without really understanding they've done that.
It would be good to have a project under the examples/ folder that has unencrypted websockets/http and explains in a readme what our intended use of this would be (i.e. only in containerized environments where the ssl termination occurs in a sidecar setup at the pod level.)
As said, am happy to approve for now, but lets create another ticket to track this.
Chris
There was a problem hiding this comment.
Yeah makes sense. Let me do that
junaidzm13
force-pushed
the
1203-add-config-option-to-disable-ssl
branch
from
04b4c97 to
13ae49f
Compare
junaidzm13
force-pushed
the
1203-add-config-option-to-disable-ssl
branch
from
13ae49f to
d652bdf
Compare
Summary of the changes:
sslin the demo app by setting the propertyvuu.ssltotrue/false.build:app:insecureorbuild:app -- --insecure. Or if thevuuConfigis to be directly used then either specify thewebsocketUrldirectly or set thesslproperty so the fallback/default websocket url reflects the required protocol (wsvswss).