reset datasource range on ui remount #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
heswell
force-pushed
the
reset-range-on-mount
branch
from
0ae5de9 to
88662c6
Compare
junaidzm13
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI Table does not currently maintain scroll position across remount. So, if table is rendered in tabbed display and user switches to another tab, then switches back, if the user had previously scrolled away from top of table, scroll position would now be reset to top.
The dataSource DOES currently remember the viewport position, so on remount we need to reset it to top of dataset.
ALternatively (and probably better) we could restore the scroll position. Thats a bit more involved, though, so current fix will do for now.