fix filter clause editor bug when no suggestions returned #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
heswell
force-pushed
the
filter-bar-dropdown-to-combo
branch
from
2cdea3c to
5cde3fd
Compare
heswell
changed the title
heswell
commented
Jan 30, 2024
| containerRef.current?.querySelector(".vuuList-scrollContainer") ?? | ||
| null, | ||
| }; | ||
| const setContainerRef = useCallback<RefCallback<HTMLDivElement>>((el) => { |
There was a problem hiding this comment.
This is the crux of the List navigation fix. The problem was that some of the navigation functions rely on the containerRef being set. Because of the way list renders, a child of MeasuredItem, the containerRef , defined as a regular RefObject, was only set on second render. If navigation happens immediately, the ref was not yet set.
By using a RefCallback, we ensure that the refs are set immediately the List is rendered.
junaidzm13
approved these changes
Jan 31, 2024
Comment on lines
121
to
+136
| const newScrollTop = Math.max(scrollTop - clientHeight, 0); | ||
| if (newScrollTop !== scrollTop && index > 0) { | ||
| if (newScrollTop === scrollTop && index > 0) { | ||
| return 0; | ||
| } else if (newScrollTop !== scrollTop && index > 0) { | ||
| containerEl.scrollTo(0, newScrollTop); | ||
| return new Promise((resolve) => { | ||
| // We must defer this operation until after render. If Items are virtualized. | ||
| // we need to allow them to be rendered. | ||
| requestAnimationFrame(() => { | ||
| let nextIdx = index; | ||
| let nextRect; | ||
| do { | ||
| nextIdx -= 1; | ||
| nextRect = getElementByDataIndex( | ||
| containerEl, | ||
| nextIdx, | ||
| true | ||
| ).getBoundingClientRect(); | ||
| } while (nextRect.top > itemTop && nextIdx > 0); | ||
| resolve(nextIdx); | ||
| }); | ||
| }); | ||
| let nextIdx = index; | ||
| let nextRect; | ||
| do { | ||
| nextIdx -= 1; | ||
| nextRect = getElementByDataIndex( | ||
| containerEl, | ||
| nextIdx, | ||
| true | ||
| ).getBoundingClientRect(); | ||
| } while (nextRect.top > itemTop && nextIdx > 0); | ||
| return nextIdx; |
There was a problem hiding this comment.
Unrelated to this change (for the future) ->
the flow would be easier to follow if we can have a separate function to calculate the next index. For example:
if (index > 0) {
if (newScrollTop === scrollTop) {
return 0;
} else {
containerEl.scrollTo(0, newScrollTop);
return next-idx-fn(); // should have a better name obv
}
rumakt
pushed a commit
to rumakt/vuu
that referenced
this pull request
Feb 15, 2024
* fix filter clause editor bur when no suggestions returned * remove unused var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug encountered in FilterClauseEditor when typeahead service returns no suggestions
allow data to be typed and ENTER pressed to continue when typing text into combobox in filters
fix issues in list/combobox/dropdown keyboard navigation and enable more of the combobox tests
remove VirtualizedList. Not used and if we need this we will use Table
rename a couple of Filter components to avoid confusion with more generic components