Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VUU-333: Fix Toast Animation #1042

Merged
merged 2 commits into from
Dec 5, 2023
Merged

VUU-333: Fix Toast Animation #1042

merged 2 commits into from
Dec 5, 2023

Conversation

pling-scottlogic
Copy link
Contributor

Description

Fixes the entry animation for toast notifications.

Change List

  • Add nominal timeout around the function that puts the notification on screen
  • Refactor: remove unnecessary CSS class

Testing

  • Tested manually on both showcase and sample app
  • Manual testing performed in Firefox, Edge and Chrome

Test Evidence

Before

Image

After

SLVUU123-toast-animation-fixed

@netlify Netlify
Copy link

netlify bot commented Dec 4, 2023 •
edited
Loading

✅ Deploy Preview for papaya-valkyrie-395400 canceled.

Name Link
🔨 Latest commit 0190350
🔍 Latest deploy log https://app.netlify.com/sites/papaya-valkyrie-395400/deploys/656db7e66d5b260008dbbf30

@pling-scottlogic pling-scottlogic mentioned this pull request Dec 5, 2023
Open
@heswell heswell merged commit 69509a4 into finos:main Dec 5, 2023
9 checks passed
@pling-scottlogic pling-scottlogic mentioned this pull request Dec 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pling-scottlogic @heswell