Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate component tests with "Test UI" workflow #1134

Closed
2 tasks done
junaidzm13 opened this issue Jan 18, 2024 · 0 comments
Closed
2 tasks done

Integrate component tests with "Test UI" workflow #1134

junaidzm13 opened this issue Jan 18, 2024 · 0 comments
Assignees
Labels
UI user Interface

Comments

@junaidzm13
Copy link
Contributor

junaidzm13 commented Jan 18, 2024

Since, now we have some Cypress component tests in place, it's a good time to have those tests as part of the UI testing workflow on the pipeline.

It could help identify bugs when changes are pushed on a PR and before a change is merged into main - reducing regression issues and increasing developer efficiency.

Proposed changes:

  • fix all currently failing component tests
  • enable cypress component testing in test-ui workflow
@junaidzm13 junaidzm13 changed the title Integrate component testing with test ui pipeline Integrate component tests with test UI pipeline Jan 18, 2024
@junaidzm13 junaidzm13 changed the title Integrate component tests with test UI pipeline Integrate component tests with "Test UI" workflow Jan 18, 2024
@junaidzm13 junaidzm13 self-assigned this Jan 18, 2024
@junaidzm13 junaidzm13 added the UI user Interface label Jan 18, 2024
@junaidzm13 junaidzm13 moved this to 📋 Backlog in Vuu board Jan 18, 2024
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 18, 2024
- fixes cy test files types/linting issues by removing `*.cy.*`
  from excluded files in `tsconfig.json`
- finos#1134 also fixes failing `Tabstrip.cy.tsx` tests. Now all cypress
  component tests are passing.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 18, 2024
- fixes cy test files types/linting issues by removing `*.cy.*`
  from excluded files in `tsconfig.json`
- finos#1134 also fixes failing `Tabstrip.cy.tsx` tests. Now all cypress
  component tests are passing.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 18, 2024
- fixes cy test files types/linting issues by removing `*.cy.*`
  from excluded files in `tsconfig.json`
- finos#1134 also fixes failing `Tabstrip.cy.tsx` tests. Now all cypress
  component tests are passing.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 18, 2024
- fixes cy test files types/linting issues by removing `*.cy.*`
  from excluded files in `tsconfig.json`
- finos#1134 also fixes failing `Tabstrip.cy.tsx` tests. Now all cypress
  component tests are passing.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 18, 2024
- fixes cy test files types/linting issues by removing `*.cy.*`
  from excluded files in `tsconfig.json`
- finos#1134 also fixes failing `Tabstrip.cy.tsx` tests. Now all cypress
  component tests are passing.
@junaidzm13 junaidzm13 moved this from 📋 Backlog to 🔖 To be merged in Vuu board Jan 22, 2024
heswell pushed a commit that referenced this issue Jan 22, 2024
* #1074 enable date filtering using DatePicker

- adds `tableConfig` props to `FilterBar` as column descriptors are
  required to differentiate between a date/time and a long column.
- since for now we're assuming that server side filter handling would
  stay unchanged (treated same as long), had to add some extra mapping
  where we convert filter object to query (filterAsQuery). It is to
  handle special cases of `=` and `!=` with dates as epoch-milis.
- This change also fixes some of the bugs with the way we displayed
  tooltip (with details of applied filters) on FilterPill. Now it
  also displays the heirarchy between multi clause filters which
  wasn't visible before.

* #1074 fix bugs related to editing multi-clause filters

Bugs fixed:
1) it errored when editing a multi clause filter -> because when focus
   changed to a non-first edited filter clause that changed active index
   to include those indices, but when we saved the change it tried
   accessing filter at that index it was undefined (multi clause
   filter is considered as one when not being edited but as multiple
  when edited).
2) now we also keep name unchanged when a filter is edited, since the user
   would find it annoying to rename filter everytime a user edits it.

* #1074 add FilterBar component tests with cypress

- fixes cy test files types/linting issues by removing `*.cy.*`
  from excluded files in `tsconfig.json`
- #1134 also fixes failing `Tabstrip.cy.tsx` tests. Now all cypress
  component tests are passing.

* #1074 hook dependency list lint fixes for DatePicker

* #1074 add small improvements & suggested changes from review

- fixed package references in import statements (now using named
  package imports `@finos/*` instead of `packages/*`)
- naming improvements
- FilterBar API to take in only `ColumnDescriptors[]` instead of the
  whole `TableConfig` as the rest of table config is not needed on
  filters.
@junaidzm13 junaidzm13 moved this from 🔖 To be merged to 👀 To be tested in QA in Vuu board Jan 25, 2024
@naleeha naleeha closed this as completed Apr 17, 2024
@github-project-automation github-project-automation bot moved this from 👀 To be tested in QA to ✅ Done in Vuu board Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI user Interface
Projects
Archived in project
Development

No branches or pull requests

2 participants