Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint and type checks to CI/CD flow #1096

Closed
2 tasks done
junaidzm13 opened this issue Jan 3, 2024 · 0 comments
Closed
2 tasks done

Add lint and type checks to CI/CD flow #1096

junaidzm13 opened this issue Jan 3, 2024 · 0 comments
Assignees
@junaidzm13
Labels
enhancement New feature or request UI user Interface

Comments

@junaidzm13
Copy link
Contributor

junaidzm13 commented Jan 3, 2024 •
edited
Loading

Description of Problem:

Currently we do not run lint or typecheck on our CI/CD, which results in unidiomatic (or code not adhering to certain rules) or even worse buggy code committed to our main branch. It would be great to have these checks integrated into our CI/CD so that these issues can be caught and resolved early on in the development workflow resulting in more robust codebase and better development experience.

Potential Solutions:

  • add these checks as part of the UI test workflow
  • resolve all unused-vars errors and re-enable @typescript-eslint/no-unused-vars to emit error on failure
@junaidzm13 junaidzm13 self-assigned this Jan 3, 2024
@junaidzm13 junaidzm13 moved this to 🏗 In progress in Vuu board Jan 3, 2024
@junaidzm13 junaidzm13 changed the title Add lint and typecheck to CI/CD flow Add lint and type checks to CI/CD flow Jan 3, 2024
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 3, 2024
@junaidzm13
finos#1096 add lint and typecheck to test-ui CI/CD workflow
b34bce1 
- Our current CI/CD workflow is unable to catch any linting or
  typecheck errors. Adding these checks will help catch them
  before they are committed into main.
- This change also defines a new action `setup-vuu-ui` which
  abstracts away common steps for ui jobs leading to better
  modularity and reusability.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 3, 2024
@junaidzm13
finos#1096 fix eslint related errors
48012e9 
- eslint will ignore inlined-worker.js since its auto-generated.
- lint script to also include .ts,.tsx files.
- for now I've changed `@typescript-eslint/no-unused-vars` to
  only emit a warning as there are quite a few places where
  this rule is violated. Fixing all those with this MR
  would result in quite a big change.
- we can do a separate follow-up change to fix all those and
  then revert to emitting errors for unused vars.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 3, 2024
@junaidzm13
finos#1096 fix path casing for Tooltip.examples.tsx
114ff55
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 3, 2024
@junaidzm13
finos#1096 add lint and typecheck to test-ui CI/CD workflow
990d538 
- Our current CI/CD workflow is unable to catch any linting or
  typecheck errors. Adding these checks will help catch them
  before they are committed into main.
- This change also defines a new action `setup-vuu-ui` which
  abstracts away common steps for ui jobs leading to better
  modularity and reusability.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 3, 2024
@junaidzm13
finos#1096 fix eslint related errors
db7a8aa 
- eslint will ignore inlined-worker.js since its auto-generated.
- lint script to also include .ts,.tsx files.
- for now I've changed `@typescript-eslint/no-unused-vars` to
  only emit a warning as there are quite a few places where
  this rule is violated. Fixing all those with this MR
  would result in quite a big change.
- we can do a separate follow-up change to fix all those and
  then revert to emitting errors for unused vars.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 3, 2024
@junaidzm13
finos#1096 fix path casing for Tooltip.examples.tsx
ab1f091
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 3, 2024
@junaidzm13
finos#1096 fix eslint related errors
9729514 
- eslint will ignore inlined-worker.js since its auto-generated.
- lint script to also include .ts,.tsx files.
- for now I've changed `@typescript-eslint/no-unused-vars` to
  only emit a warning as there are quite a few places where
  this rule is violated. Fixing all those with this MR
  would result in quite a big change.
- we can do a separate follow-up change to fix all those and
  then revert to emitting errors for unused vars.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 3, 2024
@junaidzm13
finos#1096 fix path casing for Tooltip.examples.tsx
44ff872
heswell pushed a commit that referenced this issue Jan 3, 2024
@junaidzm13
#1096 add lint and typecheck to test-ui CI/CD workflow (#1095)
d1f8c5f 
* #1096 add lint and typecheck to test-ui CI/CD workflow

- Our current CI/CD workflow is unable to catch any linting or
  typecheck errors. Adding these checks will help catch them
  before they are committed into main.
- This change also defines a new action `setup-vuu-ui` which
  abstracts away common steps for ui jobs leading to better
  modularity and reusability.

* #1096 fix eslint related errors

- eslint will ignore inlined-worker.js since its auto-generated.
- lint script to also include .ts,.tsx files.
- for now I've changed `@typescript-eslint/no-unused-vars` to
  only emit a warning as there are quite a few places where
  this rule is violated. Fixing all those with this MR
  would result in quite a big change.
- we can do a separate follow-up change to fix all those and
  then revert to emitting errors for unused vars.

* #1096 fix path casing for Tooltip.examples.tsx
@junaidzm13 junaidzm13 added enhancement New feature or request UI user Interface labels Jan 3, 2024
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 23, 2024
@junaidzm13
finos#1096 fix lint unused var errors
565004a 
- with this change we also re-enable errors on unused-vars
  in eslint config.
@junaidzm13 junaidzm13 moved this from 🏗 In progress to 🔖 To be merged in Vuu board Jan 23, 2024
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 24, 2024
@junaidzm13
finos#1096 fix lint unused var errors
c61efa4 
- with this change we also re-enable errors on unused-vars
  in eslint config.
heswell pushed a commit that referenced this issue Jan 24, 2024
@junaidzm13
#1096 fix lint unused var errors (#1149)
c2a71db 
- with this change we also re-enable errors on unused-vars
  in eslint config.
@junaidzm13 junaidzm13 moved this from 🔖 To be merged to 👀 To be tested in QA in Vuu board Jan 25, 2024
@naleeha naleeha moved this from 👀 To be tested in QA to ✅ Done in Vuu board Mar 1, 2024
@naleeha naleeha closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junaidzm13 junaidzm13

Labels
enhancement New feature or request UI user Interface
Projects
Vuu board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@junaidzm13 @naleeha