Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action for continuous integration #222

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

willtsai
Copy link
Contributor

Per the comment in #204 (comment), I am contributing a GitHub Action to bring continuous integration for the TraderX docker images.

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for lucky-concha-f3599f canceled.

Name Link
🔨 Latest commit fd849a6
🔍 Latest deploy log https://app.netlify.com/sites/lucky-concha-f3599f/deploys/66f092974ab0cb0008cb9266

@willtsai
Copy link
Contributor Author

@maoo -- please give this a review, thanks!

@maoo
Copy link
Member

maoo commented Sep 23, 2024

@maoo -- please give this a review, thanks!

Spotless 😄

@DovOps - FYI, this github action is supposed - for now - to be manually executed by a TraderX maintainer; could you please review/merge this PR and then run the action? Please let @willtsai know the outcome. Thanks!

@DovOps DovOps merged commit fd6ad38 into finos:main Sep 23, 2024
5 checks passed
@DovOps
Copy link
Contributor

DovOps commented Sep 23, 2024

@maoo @willtsai - I reviewed and merged this change (Thanks for putting this in!) - Action is running now.

@DovOps
Copy link
Contributor

DovOps commented Sep 23, 2024

The action failed. I didn't catch this - but traderX is case sensitive, and in your paths it's not referenced properly. This needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants