Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/update gradle wrapper #180

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Refactor/update gradle wrapper #180

merged 4 commits into from
Jun 25, 2024

Conversation

DovOps
Copy link
Contributor

@DovOps DovOps commented Jun 23, 2024

THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE FINOS Corporate Contributor License Agreement.

THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

DovOps and others added 2 commits June 23, 2024 06:08
@DovOps @TeamModerne
refactor: Update Gradle wrapper
a5bbd91 
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.gradle.UpdateGradleWrapper?organizationId=RklOT1M%3D

Co-authored-by: Moderne <team@moderne.io>
@DovOps
Updated gradle wrapper, added multi-project build to parent directory…
3e59986 
… and remediated deprecated gradle java plugin notation
@DovOps DovOps requested a review from maoo June 23, 2024 06:27
@DovOps DovOps self-assigned this Jun 23, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 23, 2024 •
edited
Loading

❌ Deploy Preview for lucky-concha-f3599f failed. Why did it fail? →

Name Link
🔨 Latest commit 958f372
🔍 Latest deploy log https://app.netlify.com/sites/lucky-concha-f3599f/deploys/667aa2ae6270e100083d99df

@DovOps
Copy link
Contributor Author

DovOps commented Jun 25, 2024

@maoo this is ready to upgrade now.

@DovOps
Copy link
Contributor Author

DovOps commented Jun 25, 2024

@maoo let me know about this one, as I think the other spring upgrade may have broken docker builds due to some missed changes to base image

@maoo
Copy link
Member

maoo commented Jun 25, 2024

@DovOps - we run the upgrade as documented on https://gist.github.com/maoo/51aef572973456437e28748200149126

We're getting a rather cryptic error:

9.359 Welcome to Gradle 8.6!
9.359 
9.360 Here are the highlights of this release:
9.360  - Configurable encryption key for configuration cache
9.360  - Build init improvements
9.360  - Build authoring improvements
9.360 
9.360 For more details see https://docs.gradle.org/8.6/release-notes.html
9.361 
9.753 Starting a Gradle Daemon (subsequent builds will be faster)
74.06 > Task :compileJava FAILED
74.16 
74.16 FAILURE: 
74.16 Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
74.16 
74.16 You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

It seems that Gradle Forum responses don't help much either - https://discuss.gradle.org/t/deprecated-gradle-features-were-used-in-this-build-making-it-incompatible-with-gradle-9-0/48195

With OSFF tomorrow, we don't have bandwidth to debug this, but right now https://demo.traderx.finos.org is down.

I'll try to revert to the previous version for now, but would be great if someone can investigate what is going on.

@maoo
Copy link
Member

maoo commented Jun 25, 2024

@maoo let me know about this one, as I think the other spring upgrade may have broken docker builds due to some missed changes to base image

Looks like we typed at the same time 😄 .

Is there any step of the deployment process that needs adapting?

@DovOps
Copy link
Contributor Author

DovOps commented Jun 25, 2024

@maoo merge this - it fixes this

@DovOps
Copy link
Contributor Author

DovOps commented Jun 25, 2024

@maoo this is fixed per https://github.com/DovOps/traderX/actions/runs/9661172553

@maoo maoo merged commit ede9795 into finos:main Jun 25, 2024
1 of 5 checks passed
@maoo
Copy link
Member

maoo commented Jun 25, 2024

@maoo merge this - it fixes this

🤦 of course.

We're back and up to date - https://demo.traderx.finos.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maoo maoo Awaiting requested review from maoo

Assignees

@DovOps DovOps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DovOps @maoo