Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatter Maven plugin #864

Merged
merged 41 commits into from
Dec 11, 2024
Merged

Formatter Maven plugin #864

merged 41 commits into from
Dec 11, 2024

Conversation

maria77102
Copy link
Contributor

This PR deals with the 4th point of issue #858.

Type of change

  • New feature (non-breaking change which adds functionality)

maria77102 and others added 20 commits October 23, 2024 13:19
@maria77102
Created formatter interface
cf5ef6e
@maria77102
Implement interface + first Test
b124d3a
@maria77102
Fix formatting test + implementation
777832c
@maria77102
Enhanced test suite
b7d3057
@maria77102
Implement suggested changes
d2c7c2c
@maria77102
Improved interface methods/exception handling and added logging
619d38c
@maria77102
Added formatting tool method
a57b7ee
@maria77102
Add dependencies for logging in tools project
c8bc3b4
@maria77102
Improve implementation of command line tool
6e09f6d
@maria77102
Formatting java code
abca32a
@maria77102
Made formatting happen in-memory
5591d3d
@maria77102
Update logs when resource saved
b36f60c
@maria77102
Fixed logger class name
2f84974
@maria77102
Starting code for formatter plugin
7cf4bd2
@maria77102
Merge branch 'main' into formatter-maven-plugin
116995c
@maria77102
Incorporate 'format' goal in existing plugin
b65a756
@maria77102
Cleanup files
6ca9578
@maria77102
Add test cases for edge cases and unusual behavior
6e23194
@maria77102
Update code to deal with runtime exceptions
f8cd98e
@maria77102
Fix formatting errors with Choice and parenthesis
956fb9c
@maria77102 maria77102 marked this pull request as ready for review November 20, 2024 09:28
SimonCockx
SimonCockx reviewed Dec 4, 2024
View reviewed changes
rosetta-tools/pom.xml Outdated Show resolved Hide resolved
@maria77102 maria77102 marked this pull request as ready for review December 11, 2024 09:56
@SimonCockx SimonCockx merged commit f1f8f37 into finos:main Dec 11, 2024
3 checks passed
@SimonCockx SimonCockx deleted the formatter-maven-plugin branch December 11, 2024 11:13
@minesh-s-patel minesh-s-patel mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonCockx SimonCockx SimonCockx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maria77102 @SimonCockx