New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

819 switch operation #829

Merged

davidalk merged 32 commits into finos:main from REGnosys:819-switch-operation

Sep 13, 2024

Contributor

davidalk commented Sep 6, 2024 •

edited

Loading

Support for switch syntax in expressions as outlined in issue #819

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

davidalk added 11 commits

September 5, 2024 14:13


          save

8ba1d54


          build switch without enum completeness awareness

822c97e


          implement switch with enum or literal condition only

55a63cb


          fix validation

57c06f0


          add validation test for mismatched switch conditions

1a54e6a


          validate missing enum values

f6f7b4a


          add validation test for missing enum values with default present

f426838


          fix test

21cfc26


          fix switch generate


          Merge remote-tracking branch 'origin/main' into 819-switch-operation

6df1d31


          Merge branch 'main' into 819-switch-operation

18a4d4b

davidalk marked this pull request as ready for review

September 11, 2024 09:27


          update documentation with switch and update operator precendance

67eaecc

SimonCockx linked an issue

that may be closed by this pull request

Support for a switch operation #819

Closed

SimonCockx reviewed

View reviewed changes

docs/rune-modelling-component.md Outdated Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

docs/rune-modelling-component.md Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

docs/rune-modelling-component.md Outdated Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

docs/rune-modelling-component.md Outdated Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

docs/rune-modelling-component.md Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/model/RosettaExpression.xcore Outdated Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/model/RosettaExpression.xcore Outdated Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/src/main/java/com/regnosys/rosetta/Rosetta.xtext Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

...-lang/src/main/java/com/regnosys/rosetta/generator/java/expression/ExpressionGenerator.xtend Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/model/RosettaExpression.xcore Outdated Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

...-lang/src/main/java/com/regnosys/rosetta/generator/java/expression/ExpressionGenerator.xtend Outdated Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

...-lang/src/main/java/com/regnosys/rosetta/generator/java/expression/ExpressionGenerator.xtend Outdated Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/src/main/java/com/regnosys/rosetta/types/RosettaTypeProvider.xtend Outdated Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/src/main/java/com/regnosys/rosetta/types/RosettaTypeProvider.xtend Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/src/main/java/com/regnosys/rosetta/validation/RosettaSimpleValidator.xtend Outdated Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/src/main/java/com/regnosys/rosetta/validation/RosettaSimpleValidator.xtend Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/src/main/java/com/regnosys/rosetta/validation/RosettaSimpleValidator.xtend Outdated Show resolved Hide resolved

davidalk added 20 commits

September 12, 2024 15:18


          update docs with review comments

f19eaee


          Rename CaseStatement to SwitchCase

8e91ff7


          inline default switch case statement

7092f22


          renames SwitchOperation.values to SwitchOperation.cases

7fb47aa


          Handle switch statement with only default and no cases

11b636e


          fix typo

d13fc8a


          fix spacing

1f05803


          fix spacing

55d99d2


          fix typo

c409a75


          neaten up recursion logic

db9d68f


          take switch return type from context

25b86d5


          Show missing enum values on validation

11cc253


          Prevent multi cardinality inputs

ae057ac


          Only allow basic and enum type switch inputs

c178705


          Improve invalid switch argument message

411038e


          Rename switch conditions to guards

bf74696


          Test for handling multi cardinality results


          Merge remote-tracking branch 'origin/main' into 819-switch-operation

69fec54


          fix formatting

d92c87f


          fix whitespace diffs

9307c4a

davidalk enabled auto-merge (squash)

September 13, 2024 12:37

SimonCockx approved these changes

View reviewed changes

davidalk merged commit b0676e5 into finos:main

3 checks passed

SimonCockx deleted the 819-switch-operation branch

September 13, 2024 14:01

minesh-s-patel mentioned this pull request

constructor quick fix #886

Open

minesh-s-patel mentioned this pull request

Fatal error occurs when reporting rule is not given a name #898

Merged

minesh-s-patel mentioned this pull request

add model flattern #900

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet