-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STORY-1740: omit implicit parameter in operations and function calls #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCockx
commented
Dec 2, 2022
SimonCockx
commented
Dec 2, 2022
...egnosys.rosetta.tests/src/com/regnosys/rosetta/generator/java/docrefs/DocReferenceTest.xtend
Show resolved
Hide resolved
SimonCockx
commented
Dec 2, 2022
...sys.rosetta.tests/src/com/regnosys/rosetta/generator/java/expression/ListOperationTest.xtend
Show resolved
Hide resolved
SimonCockx
commented
Dec 2, 2022
...s.rosetta.tests/src/com/regnosys/rosetta/generator/java/function/FunctionGeneratorTest.xtend
Show resolved
Hide resolved
SimonCockx
commented
Dec 2, 2022
...s.rosetta.tests/src/com/regnosys/rosetta/generator/java/function/FunctionGeneratorTest.xtend
Show resolved
Hide resolved
SimonCockx
commented
Dec 2, 2022
...s.rosetta.tests/src/com/regnosys/rosetta/generator/java/function/FunctionGeneratorTest.xtend
Show resolved
Hide resolved
SimonCockx
commented
Dec 2, 2022
...egnosys.rosetta.tests/src/com/regnosys/rosetta/generator/java/rule/ConditionTestHelper.xtend
Show resolved
Hide resolved
SimonCockx
commented
Dec 2, 2022
com.regnosys.rosetta.tests/src/com/regnosys/rosetta/tests/RosettaExpressionsTest.xtend
Show resolved
Hide resolved
SimonCockx
commented
Dec 2, 2022
SimonCockx
commented
Dec 2, 2022
SimonCockx
commented
Dec 2, 2022
SimonCockx
commented
Dec 2, 2022
com.regnosys.rosetta/src/com/regnosys/rosetta/generator/java/util/JavaNames.xtend
Show resolved
Hide resolved
hugohills-regnosys
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
it
foritem
. (need to decide on a final name for it!)extract [...]
,sum
,CallToFunc
,+10
, etc, translates toit extract [...]
,it sum
,CallToFunc(it)
,it+10
)item
/it
to reference the instance being checked.item
/it
wherever it exists, no need to writeitem ->
.Bug fixes (that I know of):
item
in a context where it doesn't exist is not allowed anymore.and lots and lots of clean-ups.
Two particular challenging technicalities:
RosettaCallableCall
) and function calls (RosettaCallableWithArgsCall
), because there might not be any parentheses. I therefore joint the concept into one:RosettaSymbolReference
. This had a lot of impact in every part of the project.it
init sum
whereit
is a list ofFoo
=> should give a type error onit
). Xtext by default just red-underlines the container (e.g., in this casesum
would be red-underlined instead ofit
, which is okay for now), but Xsemantics filters out these validation errors. That needed a fix: seeRetainXsemanticsIssuesOnGeneratedInputsFilter
.