Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@finos/perspective-viewer-datagrid Bug Fixes #997

Merged
merged 2 commits into from
Mar 31, 2020
Merged

@finos/perspective-viewer-datagrid Bug Fixes #997

merged 2 commits into from
Mar 31, 2020

Conversation

texodus
Copy link
Member

@texodus texodus commented Mar 31, 2020

A few fixes for @finos/perspective-viewer-datagrid:

  • Fixes re-attach logics when datagrid is de-selected, then re-selected, and the perspective-viewer does not have overflow: hidden applied.
  • Fixed renderer virtual page calculcation when row height is overridden via CSS.
  • Fixes renderer virtual size calculation when padding is applied to <div> wrapper.
  • Refactored auto-size logic to occur after custom events are fired, ensuring custom styles have their widths accommodated for.

@texodus texodus merged commit e331c25 into master Mar 31, 2020
@texodus texodus added bug Concrete, reproducible bugs JS labels Mar 31, 2020
@texodus texodus deleted the datagrid-bug-fixes branch September 2, 2020 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texodus @finos-admin