Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@finos/perspective-viewer-datagrid Tree Formatting #993

Merged
merged 3 commits into from
Mar 31, 2020

Conversation

texodus
Copy link
Member

@texodus texodus commented Mar 29, 2020

Adds type-aware formatting and customization to tree headers.

Screen Shot 2020-03-27 at 2 43 19 AM

Also cleans up DOM initialization methods in scroll_panel.js and view_model.js (now tree_row_header.js); these now use innerHTML and template literal strings, but with a custom babel plugin babel-plugin-transform-tagged-literal.js which strips format whitespace, which would otherwise be ignored by the minifier (Terser).

@timkpaine timkpaine added enhancement Feature requests or improvements JS labels Mar 29, 2020
@texodus texodus merged commit c334402 into master Mar 31, 2020
@texodus texodus deleted the datagrid-row-format branch March 31, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants