Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typings to include nodejs only components #980

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Update typings to include nodejs only components #980

merged 2 commits into from
Mar 17, 2020

Conversation

zemeolotu
Copy link
Contributor

This PR adds typings for WebSocketServer, WebSocketManager and other nodejs components. Also included a typescript nodejs example

Fixes #971

texodus
texodus approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good, the new express-typescript example is a great addition! I think we'll need to start hosting these somewhere ...

@texodus texodus merged commit 1b78d1d into master Mar 17, 2020
@texodus texodus deleted the node-typings branch March 17, 2020 19:15
@texodus texodus added internal Internal refactoring and code quality improvement JS labels Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebSocketServer missing from TypeScript mapping
3 participants
@zemeolotu @texodus @finos-admin